[MPlayer-dev-eng] [PATCH] disable libdv by default
Reimar.Doeffinger at gmx.de
Sat Mar 7 16:03:48 CET 2009
On Sat, Mar 07, 2009 at 03:41:57PM +0100, Dominik 'Rathann' Mierzejewski wrote:
> On Saturday, 07 March 2009 at 15:40, Reimar Döffinger wrote:
> > libdv has a rather unreliable auto-detection and I think that
> > libavformat/libavcodec in general work better for it (if not we will get
> > some bug reports).
> > Thus I propose disabling libdv unless explicitly disabled. I admit that
> > having libdv installed is reason to suggest the user wants it to be
> > used, but in case of libdv I think there are simply other programs that
> > indeed need it whereas for MPlayer it mostly causes issues.
> What issues does it cause?
Mostly: broken files mis-detected as DV. Could of course be avoided by
adding another check on top of the libdv check in the demuxer, but
that's extra effort...
Maybe a bit unfair, but that the last activity of any kind on libdv
seems to have been in 2006 could maybe be considered a concern.
Also the native DV demuxer is one of those places that regularly allocates > 100 kB
on the stack and disabling libdv is a quick way to disabling that
If libdv works with the libavformat demuxer, just ripping out the native
DV demuxer might be an option, too, though.
More information about the MPlayer-dev-eng