[MPlayer-dev-eng] [PATCH] Fix unpause with key_down_event command

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sat Mar 7 14:27:42 CET 2009


On Sat, Mar 07, 2009 at 02:05:11PM +0100, Adrian Stutz wrote:
> On Fri, Mar 6, 2009 at 10:56 AM, Reimar Döffinger
> <Reimar.Doeffinger at gmx.de>wrote:
> > On Thu, Mar 05, 2009 at 10:25:44PM +0100, Adrian Stutz wrote:
> > > ping.
> > >
> > > It's been almost two months. Any news on this patch?
> >
> > Well, firstly it is not impossible, adding pausing_keep_force in front
> > would make it behave as you want already.
> > Also heaping input logic stuff into mplayer.c is not going to work in
> > the long term.
> > It also silently overrides the effects of any pausing, pausing_toggle
> > etc. prefix, even though those are is unlikely to be useful, that kind
> > of inconsistency is not helpful.
> > How would attached patch work for you?
> 
> 
>  I thought I did try those prefixes but I probably had confused pausing_keep
> and pausing_keep_force.

The slave-mode interface unquestionably has its warts...

> Anyway, thanks for the patch! It works as expected in my tests.
> I went for the most simple solution but your patch is cleaner.

Applied then.



More information about the MPlayer-dev-eng mailing list