[MPlayer-dev-eng] [PATCH]: reduce vsync wait in VDPAU

Dan Oscarsson Dan.Oscarsson at tietoenator.com
Wed Mar 4 20:12:54 CET 2009


On 2009-03-04 at 08:49 -0800 Stephen Warren wrote:
> Dan Oscarsson wrote:
> > 
> > I did some testing yesterday and so far it looks like queued surfaces in
> > the presentation queue do not move forward to be displayed. I had nearly
> > the same when I tried with my patches when using the 180.22 driver. Then
> > it looked like if you did not do "wait for idle on presentation queue",
> > the queue never moved forward.
> 
> Aha. Yes, that's the bug; for the blit-based presentation queue only, the
> surface status was not being updated by query_surface_status, only by
> block_until_surface_idle.
> 
> I hadn't noticed this before, because the tracing inside the PQ implementation
> was printing out the correct progression of state changes; I just hadn't
> realized that those updates were only happening from one of the two places it
> needed to. I hacked vo_vdpau.c to dump the state of all 6 surfaces each time,
> then it was obvious.
> 
> This bug will be fixed in the next driver release. Thanks for pointing it out.

I tested Reimar Döffinger's patch om my computer where I do not have
composite enabled, and then it works. So it is this bug that made it
fail for him (and me when running with composite enabled so that the
blitting were used).

Regards,

   Dan




More information about the MPlayer-dev-eng mailing list