[MPlayer-dev-eng] [PATCH] ao_dart

[KO Myung-Hun]

Hi/2.

Diego Biurrun wrote:
>> But, now the closing bracket '}' of last case is placed on the same
>> depth with the closing bracket '}' of switch. I think it's not good
>> style.
>>     
>
> Just look at what K&R really does: Indent the opening brace after 'case'.
>
>   

How do I that in this case ?

    case 1234:
        {
        if (true) {
        }
        break;
        }

Just do that ?


>>>> +static int play(void *data, int len, int flags)
>>>> +{
>>>> +
>>>> +     if (!(flags & AOPLAY_FINAL_CHUNK))
>>>> +        len = (len / ao_data.outburst) * ao_data.outburst;
>>>> +
>>>> +     return write_buffer(data, len);
>>>>         
>>> one space indentation too much
>>>       
>> Fixed. I think you have a eagle's eye. ^^
>>     
>
> Try the indent program, 'indent -i4 -kr -nut' is what trains my eyes.
>
>   

Thanks for the info.

>>> Please make sure your patches really apply.
>>>       
>> Strange, it works fine here.
>>     
>
> It worked here now as well, patch applied.
>   

Thanks.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 1.1.14
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 1 GHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr