[MPlayer-dev-eng] [PATCH] vo_kva

[KO Myung-Hun]

Hi/2.

KO Myung-Hun wrote:
> Hi/2.
>
> Diego Biurrun wrote:
>   
>> On Thu, Feb 26, 2009 at 12:00:23AM +0900, KO Myung-Hun wrote:
>>   
>>     
>>> This patch adds a vo_kva for OS/2 video system.
>>>
>>> --- libvo/vo_kva.c	(revision 0)
>>> +++ libvo/vo_kva.c	(revision 0)
>>> @@ -0,0 +1,1194 @@
>>> +
>>> +typedef struct tagVOKVAINTERNAL {
>>> +} VOKVAINTERNAL, *PVOKVAINTERNAL;
>>>     
>>>       
>> typedefs are ugly..
>>
>>   
>>     
>
> Ok.
>
>   
>>> +extern void mplayer_put_key(int code);            // let mplayer handel the keyevents
>>>     
>>>       
>> handLe
>>
>> Forward declarations are ugly, please #include the appropriate
>> header instead.
>>
>>   
>>     
>
> Ok.
>
>   
>>> +static VOID imgCreate(VOID)
>>>     
>>>       
>> VOID?
>>
>>   
>>     
>
> OS/2 stuff.
>
>   
>>> +            //if (ustflags & (TF_LEFT | TF_RIGHT | TF_TOP | TF_BOTTOM | TF_SETPOINTERPOS))
>>> +            {
>>> +            #if 0
>>> +                pti->rclBoundary.xLeft   = 0;
>>> +                pti->rclBoundary.yBottom = 0;
>>> +                pti->rclBoundary.xRight  = vo_screenwidth;
>>> +                pti->rclBoundary.yTop    = vo_screenheight;
>>> +            #endif
>>>     
>>>       
>> What is this disabled code good for?  If it's good for nothing, get rid
>> of it.
>>   
>>     
>
> It is for tracking boundary. If it's set, movie window does not go out 
> of screen. If possible, I want to preserve it. If needed, I'll add 
> comments for it.
>
>   
>>   
>>     
>>> +static void uninit(void)
>>>     
>>>       
>> Now it's plain 'void'.  I think the lowercase version is preferable.
>>
>>   
>>     
>
> Non-OS2 stuff. Anyway I agree with you.
>
>   
>>> +static int config(uint32_t width, uint32_t height, uint32_t d_width, uint32_t d_height, uint32_t flags, char *title, uint32_t format)
>>>     
>>>       
>> Please break such long lines, same in other places.
>>
>>   
>>     
>
> Ok.
>
>   

I attach the updated patch.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 1.1.14
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 1 GHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: kva.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090301/3597a13a/attachment.asc>