[MPlayer-dev-eng] [PATCH] Print chapter info with -identify

[Adrian Stutz]

On Sat, Jun 27, 2009 at 8:10 PM, Reimar
Döffinger<Reimar.Doeffinger at gmx.de> wrote:
> On Sat, Jun 27, 2009 at 07:57:12PM +0200, Adrian Stutz wrote:
>> This patch updates demuxer_add_chapter to print all known chapter
>> information in a similar style to the video, audio and subtitle stream
>> messages.
>
> IMHO your patches are a bit the wrong way round, I think it would be better
> if chapter counting started with 0, just like the stream IDs, even though
> I admit it is not ideal for e.g. DVD chapters.

I did first tend to change all to zero-based numbering but then
diverted away from it because this way all chapter numbers can be
consistent in the output, slave commands, the osd as well as how
chapters are usually numbered.

AFAIK, hinted by the recent patch to change the upper limit for
switch_audio/video, the audio and video stream IDs don't necessarily
need to represent a zero-based index, either.

I also don't see a strong point in favor of a zero-based index. Sure
it's easier to just use the array index but I think the fact that the
ID then would be handled differently depending on the context is a
bigger issue.

Though it's not that I care so much. If you insist, I'll update the
patches to zero-based numbering.

Greetings
Adrian