[MPlayer-dev-eng] [PATCH] Print chapter info with -identify

Steve Dibb beandog at gentoo.org
Sat Jun 27 20:28:52 CEST 2009


Reimar Döffinger wrote:
> On Sat, Jun 27, 2009 at 07:57:12PM +0200, Adrian Stutz wrote:
>> This patch updates demuxer_add_chapter to print all known chapter
>> information in a similar style to the video, audio and subtitle stream
>> messages.
> 
> IMHO your patches are a bit the wrong way round, I think it would be better
> if chapter counting started with 0, just like the stream IDs, even though
> I admit it is not ideal for e.g. DVD chapters.

Well, with playback, you never seek to chapter 0.  You start at 1, and 
go from there.

Plus, it's consistent with everything else that reads chapters.

$ dvdxchap /dev/dvd | head
libdvdread: Using libdvdcss version 1.2.10 for DVD access
CHAPTER01=00:00:00.000
CHAPTER01NAME=Chapter 01
CHAPTER02=00:07:08.000
CHAPTER02NAME=Chapter 02
CHAPTER03=00:14:40.500
CHAPTER03NAME=Chapter 03
CHAPTER04=00:20:37.500
CHAPTER04NAME=Chapter 04
CHAPTER05=00:21:37.167
CHAPTER05NAME=Chapter 05

Steve



More information about the MPlayer-dev-eng mailing list