[MPlayer-dev-eng] [Patch] h.264 sps scaling list parsing fix

Carl Eugen Hoyos cehoyos at ag.or.at
Wed Jun 24 23:55:52 CEST 2009


Hi!

Marco Munderloh <munderl <at> tnt.uni-hannover.de> writes:

> As viewing the patch, I recognized that a function made for returning an
> singed value but specified as "static unsigned int" is totally stupid...
> 
> Find attached a corrected version.

I cannot comment on functionality (could you point to a test-case?), but I do
have a comment:

> -    if(getbits(buf, n++, 1)){

[...]

> +    if(getbits(buf, n++, 1))
> +    {

We call this a "cosmetic" change which must not be mixed with functional
changes, please remove it and resend.

Carl Eugen




More information about the MPlayer-dev-eng mailing list