[MPlayer-dev-eng] [PATCH] Network synchronized playback using UDP

[Jason Holt]

> > +<para>
> > +On each slave, run:
> > +</para>
> > +
> > +<screen>
> > +mplayer -udp-slave videoN.mpg
> > +</screen>
>
> It is not clear what you are referring to with 'N'.


As I mentioned before, N is a traditional metavariable for natural numbers.
If you have 3 slaves, they'd presumably be playing video2.mpg through
video4.mpg while the master plays video1.mpg.  This should be clear to most
people, and not harmful to those who don't get it (it's perfectly fine if
they assumed the slaves were going to play a file called videoN.mpg.)


Please keep options in alphabetical order.


done


Please consistently use K&R style, i.e. 'if ('.


done


> --- mplayer.h (revision 29317)
> > +++ mplayer.h (working copy)
> > @@ -47,7 +47,7 @@
> >
> > -void exit_player(const char* how);
> > +void exit_player(exit_reason_t);
>
> Unrelated?


Necessary for my patch to work, but yes, it should be fixed irrespective of
my patch.


missing license header


done


> Please place system #includes before local #includes.
>

done


> Use 4 spaces as indentation for new files.


done


> +    servaddr.sin_family = AF_INET;
> > +    servaddr.sin_addr.s_addr = htonl(INADDR_ANY);
> > +    servaddr.sin_port = htons(udp_port);
>
> align
>

done


> +  if (blocking) {
> > +    fcntl(sockfd, F_SETFL, sock_flags & (~O_NONBLOCK));
> > +  } else {
> > +    fcntl(sockfd, F_SETFL, sock_flags | O_NONBLOCK);
> > +  }
>
> pointless {}
>

Not pointless, since it helps avoid this:

if (foo)
    bar();
    baz();

I'll remove it if it's actually part of the mplayer style guide, though
(inasmuch as any such thing exists).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-udp-patch-13.diff
Type: text/x-diff
Size: 16681 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090601/15e2d779/attachment.diff>