[MPlayer-dev-eng] [PATCH] fix mencoder creates bad avi files when recording h264 in ts container from DVB

Attila Kinali attila at kinali.ch
Fri Jul 3 09:24:27 CEST 2009


Ciao Nico,

On Thu, 2 Jul 2009 15:06:35 +0200
Nico Sabbi <Nicola.Sabbi at poste.it> wrote:

> On Thursday 02 July 2009 14:17:06 Attila Kinali wrote:
> > On Thu, 02 Jul 2009 16:11:21 +0400
> >
> > vladisslav vladisslav <vladisslav at inbox.ru> wrote:
> > > > > > +   sh_video->disp_w=picture.display_picture_width;
> > > > > > +   sh_video->disp_h=picture.display_picture_height;
> > > > >
> > > > > Any comments on this patch?
> > > > > It seems to be trival.
> > > >
> > > > Well, if you are confident and tested it thoroughly, apply..
> > >
> > > I have used mplayer/mencoder (various svn builds) with this patch
> > > applied since January 2009 and got no problem. So i think it does
> > > not break anything.
> >
> > The question isnt whether it breaks anything, but whether the patch
> > is correct. Although it might not break anything now, it might be
> > still wrong and cause problems later when something at a very
> > different point is changed.
> >
> 
> picture must be  memset(0) before calling parse_sps(), as it should 
> have been from the beginning, my fault. After that the patch is 
> correct

Could you check+commit this patch too, when you're done?

			Attila Kinali



More information about the MPlayer-dev-eng mailing list