[MPlayer-dev-eng] [PATCH] - No Reset of D3D device on resize

[Georgi Petrov]

On Tue, Jan 27, 2009 at 2:05 PM, Reimar Döffinger
<Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> On Tue, Jan 27, 2009 at 12:05:46PM +0200, Georgi Petrov wrote:
>> Also from 1-2 threads in SMPlayer's forum I came to a conclusion that
>> under Windows 7 there are problems with gl, directx continues to
>> shutdown Aero and currently only direct3d really works.
>
> Honestly I suspect that ATI added yet another few bugs to their drivers,
> and I'd expect it will work fine with an NVidia card.
> That does not make it much better though, as long as there are crappy
> implementations like ATI's and slow/incomplete implementations like Intel's
> -vo gl indeed is not generally usable.
> I feel uncomfortable with applying some of your patches because they
> tend to change code that is not really related to the purpose of the
> patch, and in my estimation does not really change that unrelated code
> to the better.
> Since nobody else has shown interest I propose to give you commit rights
> to the repository. You should still send patches, but if nobody responds
> to them you can threaten to apply them within e.g. 3 days and do so if
> nobody objects, and for me the advantage is I don't have to apply
> patches I feel uncomfortable with.
> Does that sound reasonable to everyone?

This sounds very good to me! I will still send patches for discussion,
of course. If most of the guys agree with me or nothing happens in 3-4
days, I'll commit, taking care not to brake anything. I will commit
only to my driver, of course - that's what I'm interested in, so you
can give me right for just my file (if there is such granularity) :)

>> These days I'll install Windows 7 in a VM to start testing my code
>> there as well.
>
> Hm, how will you be able to test there? I'd expect the VM will not
> provide a usable 3D emulation - VMWare provides one but I wouldn't
> suggest it for testing.
>

Yes, VMWare has evolved far enough to have emulated video adapter with
DirectX 9.0c implementation. It's interesting - I just launched the
latest SMPlayer with direct3d and it worked without any problems under
VMWare 6.5.