[MPlayer-dev-eng] [PATCH] - No Reset of D3D device on resize

compn tempn at twmi.rr.com
Tue Jan 27 03:02:44 CET 2009


On Mon, 26 Jan 2009 23:20:55 +0100, Reimar Döffinger wrote:
>On Sun, Dec 28, 2008 at 07:08:33PM +0200, Georgi Petrov wrote:
>> I think this smooth resize patch is much better. Please, take a look.
>> I made less changes and the things are more logical now. I took into
>> account your suggestions and they turned out to be right.
>
>Well, I think the whole initialization code needs to be reworked.
>This patch reworks it already although it is not really necessary,
>nor does it fix all the issues (possible leaks).
>Unfortunately I just do not have time and inclination to fix it properly, nor to
>nit-pick every detail of this patch.
>So I can only suggest to apply it as is, and hope someone somewhen later comes
>up with a design that works also for the corner cases - any objections?

agree, apply all of georgi's patches, its his vo.
the smplayer crowd seems to be bugtesting it.
if its too unstable for mplayer , a warning can be added 'warning this
might crash!!!' etc.

smplayer also has a patch that needs review, its for ass in mencoder.

http://oss.netfarm.it/mplayer/patches/sm_ass_mencoder_embedfonts.diff
or all patches here:
http://smplayer.svn.sourceforge.net/viewvc/smplayer/mplayer-builds/patches/

it has one chunk of duplicated code that needs fixing. it includes
a filter for pts/dts modification. it fixes an old bug where vob
timestamps would reset subtitles.

-compn



More information about the MPlayer-dev-eng mailing list