[MPlayer-dev-eng] [PATCH] Multi-code events get LIRC input out of sync
uoti.urpala at pp1.inet.fi
Sun Jan 25 21:01:21 CET 2009
On Sun, 2009-01-25 at 19:46 +0100, Reimar Döffinger wrote:
> On Sat, Jan 24, 2009 at 03:56:08AM +1300, Dennis Vshivkov wrote:
> > attached is a patch I've been using for a few months in my
> > personal MPlayer Debian package.
> I have seen it, but I did and still do not like it, not being able to
> use select also means that proper "sleep until input or next frame"
> behaviour will not be possible.
> Unfortunately there seems to be no other way to fix it, so basically
> this is ok.
The separate select() in lirc.c is useless anyway. You can only sleep in
one select() at once, so all FDs must be registered for the _same_
select(), the one in input.c. I think the changes in this patch do not
lose anything useful from current code. The correct "sleep until input
or next frame" behavior would require making the code read until all
input is exhausted when called, and do that once whenever the FD becomes
readable. But that is probably better done in git.
More information about the MPlayer-dev-eng