[MPlayer-dev-eng] [PATCH]VO_VDPAU, round 5

[Stephen Warren]

Stephen Warren wrote:
> 
> > Reimar Döffinger wrote:
> >
> > > +static void calc_drwXY_dWH(uint32_t *drwX, uint32_t *drwY,\
> > > uint32_t *d_wh, uint32_t *d_ht)
> > > +{
> > > +    vo_calc_drwXY(drwX, drwY);
> > > +
> > > +    outRectVid.x0 = *drwX;
> > > +    outRectVid.y0 = *drwY;
> > > +    outRectVid.x1 = vo_dwidth+outRectVid.x0;
> > > +    outRectVid.y1 = vo_dheight+outRectVid.y0;
> > > +
> > > +    outRect.x0 = 0;
> > > +    outRect.x1 = FFMAX(vo_screenwidth, outRectVid.x1);
> > > +    outRect.y0 = 0;
> > > +    outRect.y1 = FFMAX(vo_screenheight, outRectVid.y1);
> >
> > Are these FFMAX indeed necessary? What for exactly?
> > vo_screenwidth may be unreliable. How does this handle videos
> > larger than the screen resolution (in non-fullscreen mode, so
> > the video "hangs out of the screen"?
> 
> If I Recall Correctly, We put those in explicitly so that videos
> wouldn't hang off the screen.

The previous statement of mine is incorrect.

> We attempted to make the behavior of vo_vdpau exactly match vo_xv
> as much as possible, and I believe this change was made as part of
> that effort.

That statement of mine is correct.

-- 
nvpublic