[MPlayer-dev-eng] [PATCH]VO_VDPAU, round 5

compn tempn at twmi.rr.com
Thu Jan 22 02:12:31 CET 2009

On Thu, 22 Jan 2009 03:34:27 +0100 (CET), Carl Eugen Hoyos wrote:
>Attached is the fifth round of the vo_vdpau patch.
>Please comment, Carl Eugen

i asked on irc about it, here is the reply:

[15:35] <Compn> carl got those patches accepted to ffmpeg quickly :)
[15:36] <Compn> hes waiting for a review of vo_vdpau too 
[15:36] <Compn> a fourth review that is
[16:04] <uau> IMO he could have done a better job with that
[16:04] <uau> what he posted had some rather obvious problems
[16:05] <uau> feels somewhat like posting dirty patches and expecting
others to do the actual work to make them usable... (not necessarily
wrong but i think it could at least be expressed more openly rather
than asking "for review")
[16:23] <uau> there were several things that should not have needed
pointing out
[16:33] <DonDiego> i also pointed out some issues with carl's patches
every time he posted them
[16:33] <DonDiego> and he never made changes..

did you miss some comments that diego made ? or was anything unclear
or unsaid?

do some rules need to be put in patches.txt (e.g. k&r rules
or run patch thru ispell) ?

(just trying to shrink the language barrier.)


More information about the MPlayer-dev-eng mailing list