[MPlayer-dev-eng] [PATCH]VO_VDPAU, round 4

Diego Biurrun diego at biurrun.de
Thu Jan 22 01:05:32 CET 2009

On Wed, Jan 21, 2009 at 11:54:44PM +0000, Carl Eugen Hoyos wrote:
> Diego Biurrun <diego <at> biurrun.de> writes:
> > On Sat, Jan 17, 2009 at 05:21:57AM +0100, Carl Eugen Hoyos wrote:
> > >
> > > I did not succeed in implementing pan&scan.
> > > New patch attached.
> > 
> > May I politely suggest that you iterate over it one more round
> > and fix all the obvious small issues like trailing whitespace,
> I just found one in line 221. Is this the only one? If not, please point me to
> the lines, I iterated several times now (or is there some grep magic possible?)

grep ' $' some_file

Or use an editor that highlights trailing whitespace or remove it all
with sed ...

> > inconsistent formatting,
> Do you see one outside of uninit()?

Brace placement is often inconsistent (K&R style preferred), as is the
placement of function arguments.

> > tons of errors in comments, etc.?
> I'm not a native speaker, I fixed the errors obvious to me.

There are a bunch of issues I found quite obvious.  Dunno how obvious
it is to others, but ispell or so will find some of them.


More information about the MPlayer-dev-eng mailing list