[MPlayer-dev-eng] [PATCH] VCD support for OS/2
Reimar.Doeffinger at stud.uni-karlsruhe.de
Tue Jan 20 12:47:25 CET 2009
On Mon, Jan 19, 2009 at 11:10:51PM +0100, Diego Biurrun wrote:
> On Fri, Jan 16, 2009 at 12:32:02PM +0900, KO Myung-Hun wrote:
> > No more comments ?
> > If so, apply please.
> Reimar, what do you say? Are you happy with the patch now?
Well, things like
> + BYTE bAdr : 4;
> + BYTE bControl : 4;
aren't really correct since the bit order is implementation-defined.
But if even the OS/2 developers themselves see it as so dead that they
expect that nobody will ever write a new compiler for it and do not care
about compatibility with possible future gcc versions I won't waste my
time on it (though that leaves the question if the platform is worth
including code for it).
Also quite a few structs are duplicated again in the cddb patch, which
again will complicate things when using a compiler (or
different version or different compiler flags) that somehow lays the
struct out differently.
IMHO this coding style makes maintenance difficult for no good reason,
but I don't have the time to discuss this forever.
Feel free to apply it as long as I don't get bothered with this code,
More information about the MPlayer-dev-eng