[MPlayer-dev-eng] [PATCH] VCD support for OS/2

[Diego Biurrun]

On Tue, Jan 13, 2009 at 11:01:24PM +0900, KO Myung-Hun wrote:
> 
> Diego Biurrun wrote:
> >On Tue, Jan 13, 2009 at 12:24:25PM +0900, KO Myung-Hun wrote:
> >  
> >>I've attached the updated patches as your suggestion.
> >>
> >>--- stream/vcd_read_os2.h   (revision 0)
> >>+++ stream/vcd_read_os2.h   (revision 0)
> >>+typedef struct {
> >>+    BYTE bFrame;
> >>+    BYTE bSecond;
> >>+    BYTE bMinute;
> >>+    BYTE bReserved;
> >>+} msf;
> >
> >Do you really need a typedef here?
> 
> Any problem ?

IMO the typedef is just an obfuscation.  And yes, it's used
in this way everywhere.

> >>+            mp_msg(MSGT_OPEN, MSGL_INFO, "track %02d:  adr=%d  ctrl=%d  %02d:%02d:%02d\n",
> >>+                i,
> >>+                sDataTrack.bControlInfo & 0x0F,
> >>+                (sDataTrack.bControlInfo >> 4) & 0x0F,
> >>+                sDataTrack.msfStart.bMinute,
> >>+                sDataTrack.msfStart.bSecond,
> >>+                sDataTrack.msfStart.bFrame);
> >
> >weird indentation
> 
> Fixed, but why is it weird ?

It's more sensible to align the function arguments with each other.

Diego