[MPlayer-dev-eng] [PATCH] move libdvd* checks together
Reimar.Doeffinger at stud.uni-karlsruhe.de
Sun Jan 11 12:14:08 CET 2009
On Sun, Jan 11, 2009 at 11:42:01AM +0100, Diego Biurrun wrote:
> On Sun, Jan 11, 2009 at 09:06:07AM +0100, Nico Sabbi wrote:
> > Il giorno sab, 10/01/2009 alle 14.56 +0100, Reimar Döffinger ha scritto:
> > > not sure if this is that good an approach, but this patch moves all
> > > those checks together in configure.
> > > This also ensures that the -Ilibdvd* are last on the gcc commandline and
> > > are not overridden by some -I/usr/include (of course, that one is useless
> > > and should not be there in the first place, but for some reason it is on
> > > my system).
> > it's fine with me, as long as Diego doesn't object
> Perhaps you could first repeat why it is that you moved the check to the
> end in the first place...
As I understand it, because in some configurations (linking statically
against libdvdnav, and compiling internal dvdread) you would always get
linker errors with the test programs, since contrary to MPlayer the do
not include dvdread, so you'd have to link against them explicitly.
I doubt that really applies anymore though, since internal dvdread +
external dvdnav is not supported anyway...
For fixing the -I order there are of course other possibilities, but
that depends on which way you prefer...
More information about the MPlayer-dev-eng