[MPlayer-dev-eng] [PATCH]Move calc_drwXY and fix indentation
diego at biurrun.de
Fri Jan 9 21:47:55 CET 2009
On Fri, Jan 09, 2009 at 10:16:33PM +0200, Ivan Kalvachev wrote:
> On 1/9/09, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> > Reimar Döffinger <Reimar.Doeffinger <at> stud.uni-karlsruhe.de> writes:
> >> > + vo_dwidth = FFMIN(vo_dwidth, vo_screenwidth);
> >> > + vo_dheight = FFMIN(vo_dheight, vo_screenheight);
> >> > + *drwX = (vo_screenwidth - vo_dwidth) / 2;
> >> > + *drwY = (vo_screenheight - vo_dheight) / 2;
> >> And yes, aligning these four lines while you're at it would be nice
> > Patch with changed alignment (and a forgotten call in xv) applied.
> I would like more than 5 hours to check proposed patches.
> I am still maintainer of XvMC and Reimar have given
> you permission only for Xv code.
> And no, I'm not OK with these changes for XvMC, please revert.
> There is longstanding request to implement cropping in xvmc,
> as it cannot be done in the filters, it needs tricks with PutImage.
> This won't be possible with common xv calculations.
I suggest you duplicate the code when you get around to do this.
Until then this can stay factorized. Please do not revert.
More information about the MPlayer-dev-eng