[MPlayer-dev-eng] [PATCH] internal dvdnav

[Uoti Urpala]

On Thu, 2009-01-08 at 19:09 +0100, Reimar Döffinger wrote:
> Ok, I will keep the discussion short:

I bit too short IMO, not leaving much chance to resolve anything or even
find out exactly what the differences are.

> I will be using internal dvdnav and dvdread, because anything else is
> just a pain in the backside to use, and particularly due to dvdcss

I don't see any reason why it would have to be such a pain to use a
library unless it is internal. I wouldn't really oppose having some
Makefile support for libraries so that if they're present in a
particular location they'll be rebuilt with a single 'make' without even
using a script, as long as they're not part of the source tree by
default.

> I'd expect most user and developers to feel like that too.

I'd expect most developers to agree that including the used libraries in
your source tree is a bad idea in general, and I don't see any strong
reason why this case would be an exception.

> The only question is if I should apply it or not, I don't care.
> Just don't think I'll help with any of the other proposed solutions,
> like building against a libdvd* that is not installed system-wide or
> download scripts etc.

I don't care too much exactly how much it is set up, but I think
including the library in the MPlayer tree just to make building slightly
simpler is totally excessive. The biggest problem with implementing that
myself is that I don't really have any problems just using an external
installation, so I don't know how much others would need to be happy...
For Windows a bigger script that handles typical build issues could be
useful, but that goes beyond dvdnav.

Building against a non-system-wide installation should be trivial, just
set PKG_CONFIG_PATH. If that doesn't work then it should be fixed
independently of anything in this thread.