[MPlayer-dev-eng] [PATCH]VO_VDPAU, round 2

[Reimar Döffinger]

On Tue, Jan 06, 2009 at 07:12:51PM +0200, Uoti Urpala wrote:
> > Huh? I just saw vo_xv has this too, but... what does it do?
> > (I mean, I know the function, but that
> > mp_input_add_event_fd(ConnectionNumber(mDisplay), check_events);
> > seems like a weird hack, I wonder what its purpose is, does it still
> > serve one?...).
> 
> The purpose is to allow getting events from X without polling. Without
> that you can't detect user keypresses (or any other X events) unless
> MPlayer constantly wakes up to poll for them with vo_check_events();
> registering the input file descriptor allows MPlayer to detect those
> events in the main input loop code.

So, I'd say it is correct to summarize it as "it is quite pointless
currently but could be used to improve things in the future"...

> That functionality should be added to all the other X VOs too, and the
> default sleeping mechanism changed to sleep in the input select() to
> allow instant response to user or slave events.

What I don't like about it is that it will only work with X11 and that
is what almost all developers use.
Nowadays except for xv they all use the same code, while that is far
more ugly at least it is the same for all platforms, ensuring it is well
tested.
Still, moving it to x11_common is better than what we have now, so I'd
welcome it if someone does that.

Greetings,
Reimar Döffinger