[MPlayer-dev-eng] [PATCH]VO_VDPAU, round 2

Reimar Döffinger Reimar.Doeffinger at stud.uni-karlsruhe.de
Tue Jan 6 16:05:47 CET 2009

On Tue, Jan 06, 2009 at 09:31:07AM +0100, Benjamin Zores wrote:
> I could only second that. Doxygen definitely is useless but for a library imho.

I forces at least a consistent style for documentation and it enforces
a minimum amount of documentation.
Obviously for functions that are part of the API documentation should
not be duplicated, duplicated documentation is not that much better than
duplicated code.

> Efforts should be done on code, not on cosmetics, for once.

You assume that that saved effort would actually go into code.
Also messed up indentation makes me loose interest in review very
quickly, do you intend to review it and put effort into the code?
Maybe it will be different this time, but I find it quite unfair to
leave the reviewing, applying and maintaining to others but expecting
them to use your criteria for it.

Reimar Döffinger

More information about the MPlayer-dev-eng mailing list