[MPlayer-dev-eng] [PATCH]Add vo vdpau

Uoti Urpala uoti.urpala at pp1.inet.fi
Mon Jan 5 03:54:51 CET 2009

On Mon, 2009-01-05 at 04:28 +0100, Carl Eugen Hoyos wrote:
> Attached is a first version of vo vdpau.
> When I shortly tested it, it seemed as fast as xv.
> It is of course precondition for HW accelerated VDPAU decoding.

It seems to have several problems.
All the VDPAU calls use the CHECK_ST macro with does printf+exit(1) if
there's any problem. config() silently returns success if reconfigured
without doing anything. config() also has "vo_directrendering = 1;".
That breakage is probably copied from vo_xvmc, but it makes even less
sense for vdpau; there's no get_image implementation at all so the
direct rendering code can't do anything sensible. Window creation code
is copied from an older version of vo_xv.c from before Reimar changed
it. There are likely more such issues.

The start_slice() function tries to disable slice support but there's
also a draw_slice() function. Does this combination actually do
something? At least it should be documented if so.

There's also lots of smaller stuff like bad grammar in comments, bad
code formatting (at least some copied from vo_xv), unused variable
"max_references" and an mp_msg() call saying "vo_x11:".

More information about the MPlayer-dev-eng mailing list