[MPlayer-dev-eng] [PATCH] internal dvdnav

Uoti Urpala uoti.urpala at pp1.inet.fi
Fri Jan 2 17:41:11 CET 2009

On Wed, 2008-12-31 at 11:22 +0100, Nico Sabbi wrote:
> Il giorno mer, 31/12/2008 alle 09.47 +0100, Reimar Döffinger ha scritto:
> > The dvdread part that replaces our internal copy with an svn:externals
> > entry is ready to be applied any time...
> > I am in favour of doing this rather soon, even though I am not sure how
> > well replacing an internal directory with and external will work,
> > calling the new directory e.g. libdvdread4 might be safer.
> > Any opinions?
> > 
> I agree completely with the inclusion of both externals and with your
> patch, but using different names is the only sane way to proceed: it
> eliminates any ambiguity. 

Is there any reason this should be built as an integral part of the
MPlayer build process, hardcoding its filenames in MPlayer Makefile? Why
could it not be built separately? I'd rather favor dropping such
imported (whether directly as code or as external) libraries from the
MPlayer tree if they can be built separately. If the issue is making it
easy for technically unskilled users to build MPlayer with all features
then that is IMO better solved with a separate script that downloads
extra libraries.

More information about the MPlayer-dev-eng mailing list