[MPlayer-dev-eng] [PATCH] Support for DVB subtitles

[Diego Biurrun]

On Sat, Feb 28, 2009 at 12:57:15PM +0100, Nicolas George wrote:
> Le decadi 10 ventôse, an CCXVII, Diego Biurrun a écrit :
> > > +typedef struct dvbsub_frame dvbsub_frame_t;
> > typedefs are ugly and the _t namespace is reserved by POSIX.
> 
> I do not find typedefs ugly, but changed.

Upgrade your taste ;)

> > > +    frame->start = start;
> > > +    frame->end = end;
> > > +    frame->rect = rect;
> > > +    frame->n_rect = n_rect;
> > Things like these could be aligned.
> 
> Done, in two places.

nit: one more occasion:

> --- /dev/null
> +++ b/dvbsub.c
> @@ -0,0 +1,240 @@
> +            ni->w = w;
> +            ni->h = h;
> +            ni->dst_x = x;
> +            ni->dst_y = y;
> +            ni->stride = w;
> +            ni->bitmap = malloc(w * h);

But don't bother sending an update just for this, I bet there will be
more comments.

Diego