[MPlayer-dev-eng] [PATCH] Simplify and factorize EOSD code

[Uoti Urpala]

On Thu, 2009-02-26 at 11:48 +0100, Nicolas George wrote:
> L'octidi 8 ventôse, an CCXVII, Uoti Urpala a écrit :
> > Which is not actually all that beneficial or desirable. We don't want to
> > overlay random independent bits from various places in the code. There
> > are currently a couple of places which can do that. Maybe one or even
> > two more will appear in future near enough to matter. But not enough
> > that the ease of adding more would really matter.
> 
> At least, do you agree to the following principle: adding a new source of
> overlay should not require adding code in more than one place (same file,
> neighbouring short functions)?

No. Such a feature would be positive, but too irrelevant to make that a
principle you should follow, and it is not worth much effort or added
code. Adding a new independent overlay source in the code is, and should
be, rare. Cleanup after adding a possible new subtitle source for DVB
could be better handled by creating shared code for all subtitle sources
(which would be one user from overlay use point of view). After that
there would be no expected new independent users of "general overlay"
functionality.

> That is good news. May I ask which Git repository you are talking about? I
> use the ones on git.mplayerhq.hu when I work on ffmpeg, but there is no tree
> for mplayer itself.

http://repo.or.cz/w/mplayer.git