[MPlayer-dev-eng] [PATCH] vo_macosx: fix device_id option after r28165

[Ergzay]

On Jan 18, 2009, at 1:06 PM, Guillaume POIRIER wrote:

> Hello,
>
> On Fri, Jan 9, 2009 at 4:03 PM, Adrian Stutz <adrian at sttz.ch> wrote:
>> I missed the screen_force BOOL in my patch to vo_macosx to replace  
>> the
>> custom options parsing with subopt_parse().
>>
>> Because screen_force is never set to YES anymore, the device_id  
>> option has
>> no effect on fullscreen.
>>
>> The attched patch fixes that and removes screen_force, since  
>> screen_id is
>> only used to force fullscreen anyway. The patch instead allows  
>> screen_id to
>> be negative for automatic fullscreen device selection and assumes a  
>> forced
>> selection for any positive value.
>>
>> Patch also includes update of the manpage that includes the new  
>> negative
>> value of device_id.
>
> Tested and works, thus applied.
>

I know I'm resurrecting an over a month old post but I thought I  
should say something.

While the current functionality is good with letting the user select  
the forced full screen, what should not be done is have the UI  
complain to the user that there is an error when there is not (if I am  
understanding this correctly). As currently with no device_id set,  
every time you run mplayer you get a "Get device error: Device ID -1  
do not exist, falling back to main device." This is not really an  
error, correct? A default setting shouldn't be an error setting.  
Shouldn't we instead remove said error (or change how it appears) or  
default the device ID to 0 (current display)?

Ergzay