[MPlayer-dev-eng] [PATCH] ao_dart

[Diego Biurrun]

On Thu, Feb 26, 2009 at 05:02:09AM +0900, KO Myung-Hun wrote:
> [...]

Your patch fails to apply, so here is another round of nitpicks
instead of a commit...

> --- libao2/ao_dart.c	(revision 0)
> +++ libao2/ao_dart.c	(revision 0)
> @@ -0,0 +1,332 @@
> +
> +static ao_info_t info =
> +{

The opening brace should be on the same line for K&R style...

> +static int buf_free(void) {

...but on the next line for function declarations...

> +static int control(int cmd, void *arg)
> +{
> +    switch (cmd) {
> +        case AOCONTROL_GET_VOLUME :

...and the case at the same indentation depth as the switch.

> +    int     fShare       = 1;
> +    int     nDartSamples = DEFAULT_DART_SAMPLES;
> +    int     nBytesPerSample;

weird amount of spaces

> +static int play(void *data, int len, int flags)
> +{
> +
> +     if (!(flags & AOPLAY_FINAL_CHUNK))
> +        len = (len / ao_data.outburst) * ao_data.outburst;
> +
> +     return write_buffer(data, len);

one space indentation too much


Please make sure your patches really apply.

Diego