[MPlayer-dev-eng] [PATCH] Simplify and factorize EOSD code

Uoti Urpala uoti.urpala at pp1.inet.fi
Wed Feb 25 17:19:12 CET 2009


On Wed, 2009-02-25 at 17:14 +0100, Nicolas George wrote:
> Le septidi 7 ventôse, an CCXVII, Reimar Döffinger a écrit :
> > It adds a bad assumption that was previously avoided: the pts at the
> > filters is not necessarily the same as sh_video->pts.
> 
> If so, what makes that assumption bad for ASS and not bad for other
> subtitles?

It's bad for other subtitles too.

> The current code uses a different source of timestamps for ASS subtitles and
> for non-ASS subtitles: is there a true reason behind that?

The other subtitle handling is legacy code (not that the libass using
part would be particularly nice as a whole either).




More information about the MPlayer-dev-eng mailing list