[MPlayer-dev-eng] [**13 ESSENTIAL PATCHES**] Libass enhancements that need to coincide with the new EOSD patches

Eric Appleman erappleman at gmail.com
Mon Feb 23 18:16:16 CET 2009


As my patience is wearing thing, I must repeat once again. Why are we 
implementing Greg's EOSD patches if we aren't even looking at his 13 
newest libass patches that would enhance EOSD rendering that have been 
repeatedly submitted and ignored? Why are they not getting any attention?

If you guys are content with these patches flying under the radar yet 
again, PLEASE SAY SO RIGHT HERE AND NOW.

I apologize for coming off as an ass with this message, but it seems 
that I must turn up the volume in order to be heard.

(Yes. The fixed version of patch 9 is included.)

* 0001-Ignore-PlayResX-Y-aspect-ratio-for-font-aspect-ratio.patch
vsfilter, perian, aegisub, et al ignore the PlayResX/PlayResY aspect 
ratio when scaling fonts. This replicates the behaviour.

* 0002-Allow-shadow-without-border.patch
libass always set a border of 1.0 when a shadow was used. Maybe there's 
a reason for that, but I don't know. I do know of typesets which use 
shadows without borders, though.

* 0003-Fix-memory-leak-in-blur-handling.patch
The \blur patch introduced a memory leak, as the memory that is newly 
allocated after blur size changes isn't freed. Now realloc is used 
instead. In addition, the blur size scale is in line with vsfilter.

* 0004-Fix-warnings.patch
This silents two rather harmless gcc warnings.

* 0005-Hack-use-a-compromise-to-force-somewhat-reasonable.patch
This is the "compromise" hack for the anti-aliasing "fix" I had in the 
last patch already. This might be just a hack, "wrong" and whatever, but 
it still makes the area where glyph and outline overlap a bit at least 
decent looking in all cases (which I tested).

* 0006-Support-one-of-these-braindead-vsfilter-special-case.patch
vsfilter has very stupid behaviour in case PlayResX/Y aren't specified. 
As stupid as this may be, since vsfilter is more or less the reference 
implementation, it makes sense to emulate it.

* 0007-Parse-integers-as-doubles-and-then-convert-to-the-ne.patch
Parse all integers as doubles first and later convert them to the 
nearest integer. This is the much requested "decimal point" support.

* 0008-Round-shadow-displacement-to-nearest-int.patch
There's not much to say about it.

* 0009-Add-simple-blur-with-1-2-1-for-be.patch
Use a kernel blur with [[1,2,1], [1,2,1], [1,2,1]] matrix for \be. This 
is the same filter used by vsfilter and also a bit faster than the 
gaussian blur.

* 0010-Add-support-for-compositing-of-overlapping-glyph-bor.patch
This is very experimental, comments appreciated. :)
Overlapping glyphs, especially outlines, can look very ugly, in case 
they are translucent -- the luminance just adds up!
This patch adds a pass after the final rendering, where the last two 
bitmaps, if translucent and overlapping, are composited together, e.g. 
for each pixel the maximum value of both bitmaps is used.
See http://greg.geekmind.org/mplayer/comp.png for a comparison.

* 0011-Scale-shadow-displacement-and-blur-size-like-border.patch
There's not much to say about it.

* 0012-Correctly-re-initialize-glyph_info_t.patch
It seems like a glyph_info isn't correctly re-initialized after each 
event. This leads to minor quirks with positioning in at least one case 
(gg's Maria+Holic, Episode 03, 09:06)
This patch memsets the whole glyph_info instead of only setting certain 
fields to 0.

* 0013-Pan-and-scan-correct-positions.patch
When using pan-and-scan, use correct positions.
Use correct positions for positioned events (even if they'll be
off-screen), but restrict normal subtitle events to the visible
area.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Ignore-PlayResX-Y-aspect-ratio-for-font-aspect-ratio.txt
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090223/b520fdf2/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0002-Allow-shadow-without-border.txt
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090223/b520fdf2/attachment-0001.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0003-Fix-memory-leak-in-blur-handling.txt
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090223/b520fdf2/attachment-0002.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0004-Fix-warnings.txt
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090223/b520fdf2/attachment-0003.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0005-Hack-use-a-compromise-to-force-somewhat-reasonable.txt
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090223/b520fdf2/attachment-0004.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0006-Support-one-of-these-braindead-vsfilter-special-case.txt
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090223/b520fdf2/attachment-0005.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0007-Parse-integers-as-doubles-and-then-convert-to-the-ne.txt
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090223/b520fdf2/attachment-0006.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0008-Round-shadow-displacement-to-nearest-int.txt
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090223/b520fdf2/attachment-0007.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0009-Add-simple-blur-with-1-2-1-for-be.txt
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090223/b520fdf2/attachment-0008.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0010-Add-support-for-compositing-of-overlapping-glyph-bor.txt
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090223/b520fdf2/attachment-0009.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0011-Scale-shadow-displacement-and-blur-size-like-border.txt
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090223/b520fdf2/attachment-0010.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0012-Correctly-re-initialize-glyph_info_t.txt
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090223/b520fdf2/attachment-0011.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0013-Pan-and-scan-correct-positions.txt
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090223/b520fdf2/attachment-0012.txt>


More information about the MPlayer-dev-eng mailing list