[MPlayer-dev-eng] [PATCH] EOSD support for VDPAU (2nd)

[Reimar Döffinger]

On Sun, Feb 22, 2009 at 09:32:12PM +0100, Grigori G wrote:
> Reimar Döffinger wrote:
>>> +        eosd_surfaces[found].w = i->w;
>>> +        eosd_surfaces[found].h = i->h;
>> This will make reusing far harder, since above you are comparing against
>> the dimensions of the last image that was stored in the surface, instead
>> of the real dimensions of the surface as they were allocated.
>
> Yes, that's a bug I introduced while moving code around.

Applied with minor cosmetic changes, particularly naming the structs and
especially the typedef were not really necessary.
Also things like "a = b = NULL;" are often a bad
idea with pointers, it will generate a warning when a and b differ in
type.

> From the other mail...
> > Thus the vdp_bitmap_surface_create is not duplicated, and the k
> > variable is not needed either.
> > I admit it needs one indentation level more, but I don't think that is
> > that bad...
>
> That's what I wanted to avoid, but okay.

Well, you could have put the whole code in a separate function for
example, that would have reduced the indentation level again...

Greetings,
Reimar Döffinger