[MPlayer-dev-eng] [PATCH] Remove cputable.h?

Zuxy Meng zuxy.meng at gmail.com
Fri Feb 20 22:06:12 CET 2009


Hi,

2009/2/21 Ivan Kalvachev <ikalvachev at gmail.com>:
> On 2/20/09, Zuxy Meng <zuxy.meng at gmail.com> wrote:
>> 2009/2/20 Ivan Kalvachev <ikalvachev at gmail.com>:
>>> On 2/20/09, Zuxy Meng <zuxy.meng at gmail.com> wrote:
>>>> 2009/2/20 Attila Kinali <attila at kinali.ch>:
>>>>> On Thu, 19 Feb 2009 21:30:59 +0800
>>>>> Zuxy Meng <zuxy.meng at gmail.com> wrote:
>>>>>
>>>>>> > I wouldnt. Though i only see sense to do detection ourselfs when
>>>>>> > handling
>>>>>> > pre P-II processors (iirc)... I've no clue how many of them are still
>>>>>> > in
>>>>>> > use for video decoding.
>>>>>>
>>>>>> For them, we still print the vendor, family, model and stepping as
>>>>>> well as SIMD support and I guess that's fairly enough.
>>>>>
>>>>> Well then.. go ahead
>>>>> .. unless someone else complains ;-)
>>>
>>> I complain.
>>
>> Because?
>
> line 262 contains my cpu.

A K7? mplayer prints its built in name string directly withouth the
help from cputable.h So removing this header wont' affect the output
of mplayer on you fairly up-to-date CPU.

> And I don't like removing features, even if they are not essential.

No features are removed, just dead code and an outdated table.


-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6



More information about the MPlayer-dev-eng mailing list