[MPlayer-dev-eng] [PATCH] Statistics audio filter

[Uoti Urpala]

On Fri, 2009-02-20 at 11:46 +0100, Nicolas George wrote:
> Le septidi 27 pluviôse, an CCXVII, Nicolas George a écrit :
> > The attached patch implements an "-af stats" audio filter which collects
> > statistics about the audio stream.
> 
> Ping? I think this is useful, reasonably well coded, and very unlikely to
> introduce bugs.

I suppose it could be useful, though I haven't needed such functionality
personally. I think the main question is how to display the resulting
statistics. IMO it at least shouldn't use printf(); mp_msg would be
preferable. Also maybe it should output _something_ when there were 0
samples.

There are a couple of style issues where the code doesn't follow K&R
style (function declarations are split on two lines (except af_open),
space missing after 'if' and 'for'). I'd also use 'struct af_stats'
instead of the typedef. At least drop the stupid '_s' from the struct
name; it's already preceded by 'struct' in all uses... Those are things
I could change myself easily enough before applying though.