[MPlayer-dev-eng] Why is _FILE_OFFSET_BITS=64 and _LARGEFILE_SOURCE forced?

[Hans-Christian Egtvedt]

On Thu, 19 Feb 2009 15:10:53 +0100
Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:

> On Thu, Feb 19, 2009 at 02:58:04PM +0100, Hans-Christian Egtvedt
> wrote:
> > On Thu, 19 Feb 2009 14:27:03 +0100
> > Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:

<snipp>

> > > Also it will not usually break builds, systems without largefile
> > > support usually just ignore _FILE_OFFSET_BITS and
> > > _LARGEFILE_SOURCE.
> > 
> > For uClibc users this is not the case.
> > 
> > Could the define be removed from the initial CFLAGS in common.mak,
> > and added if the --disable-largefiles switch is not set?
> 
> Oh, it is in common.mak... Hm, that file is copied 1:1 from FFmpeg,
> you should ask them about it IMO...

Okay, will do.

> I think from our side we could just remove them since they are already
> part of our OPTFLAGS unless --disable-largefiles was used, but it is
> better to keep that file in-sync with the FFmpeg version, and I am
> unsure what could break in FFmpeg (probably nothing that MPlayer uses,
> but I do not know).

I'll do a new discussion on the ffmpeg list.

-- 
Best regards,
Hans-Christian Egtvedt