[MPlayer-dev-eng] [PATCH] Add query_{, current_video_decoder_}format()

[Reimar Döffinger]

On Thu, Feb 19, 2009 at 12:42:00PM +0100, Gwenole Beauchesne wrote:
> On Thu, 19 Feb 2009, Reimar Döffinger wrote:
>
>> On Thu, Feb 19, 2009 at 11:31:29AM +0100, Gwenole Beauchesne wrote:
>>> This patch adds query_format() and query_current_video_decoder_format()
>>> functions. They will be used in vd_ffmpeg.c::get_format() to actually 
>>> query
>>> the VO for the selected format.
>>
>> Why should they be necessary? I'd expect the current init_vo code in
>> vd_ffmpeg should be able to handle everything that is necessary?
>
> No, please read the other mail. ;-) And those functions are also useful in 
> the original vd.c (to fix the FIXME as a side effect).

Well, the FIXME does not say what should be fixed, I do think the global
variable itself is the larger issue than just the extern there.
Adding mpvdec to sh_video_t seems more likely to be the right solution.
Still, that part is probably ok, whereas the query_format() seems likely
to be wrong to me, as said in my other email (though I am sure it works
fine for hardware-accelerated formats - at least as long as swscale does
not support them).