[MPlayer-dev-eng] [PATCH] Fix vd_ffmpeg.c::get_format() to actually query format (take 2)

Gwenole Beauchesne gbeauchesne at splitted-desktop.com
Thu Feb 19 11:46:43 CET 2009


On Thu, 19 Feb 2009, Gwenole Beauchesne wrote:

> This patch fixes a two-fold problem in vd_ffmpeg.c::get_format():
>
> - init_vo() was never actually testing the fmt[i] since it turned out to 
> unconditionnally test the best_csp previously set.
>
> - Besides, there are cases where init_vo() (and more precisely, 
> mpcodecs_config_vo()) is no-op because sh->disp_w and sh->disp_h are both 0 
> so we turned out to not actually test VO capabilities. IOW, get_format() can 
> be called as early as neither width nor height are parsed yet.

Err, here is the corrected patch. It was a JIT generated patch excerpted 
from my other local changes.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer.get_format.fix.2.patch
Type: text/x-diff
Size: 706 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090219/13a2b4c9/attachment.patch>


More information about the MPlayer-dev-eng mailing list