[MPlayer-dev-eng] [PATCH 3/9] ad_libmad: Use BE sample format on big endian architectures

[Hans-Christian Egtvedt]

On Tue, 17 Feb 2009 11:12:17 +0100
Hans-Christian Egtvedt <hans-christian.egtvedt at atmel.com> wrote:

> On Mon, 16 Feb 2009 17:39:15 +0100
> Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> 

<snipp patch>

> > Weird, why has that worked so far (I am not aware of any
> > complaints)? Also, for avoiding such ugly ifdefs is what
> > AF_FORMAT_S16_NE is there for.
> >
> 
> It works without, but IMHO it is more optimized for the architecture
> to match the memory model. So perhaps changing it to AF_FORMAT_S16_NE
> is the most appropriate.
> 
> Although some sound devices support byte swapping in hardware, so the
> gain may not be relative for all. Comments?
> 

When looking over the patch again I notice that setting the format has
been removed all entirely from ad_libmad.c. So I'll just leave it out
all together. This patch popped up because I rebased a really old patch
set (against v1.0rc1) to latest trunk.

-- 
Best regards,
Hans-Christian Egtvedt