[MPlayer-dev-eng] [PATCH] ao_dart

[KO Myung-Hun]

Hi/2.

Diego Biurrun wrote:
> On Wed, Feb 18, 2009 at 12:47:14AM +0900, KO Myung-Hun wrote:
>   
>> Reimar Döffinger wrote:
>>     
>>> On Tue, Feb 17, 2009 at 11:58:27AM +0900, KO Myung-Hun wrote:
>>>   
>>>       
>>>> Reimar Döffinger wrote:
>>>>     
>>>>         
>>>>> On Mon, Feb 16, 2009 at 10:17:01PM +0900, KO Myung-Hun wrote:
>>>>>         
>>>>>           
>>>>>> +    // mask off all floating-point exceptions
>>>>>> +    _control87(MCW_EM, MCW_EM);
>>>>>>         
>>>>>>             
>>>>> Hm. Quite ugly, and you don't restore them in uninit.
>>>>> Also explaining why they are needed would be good (performance reasons,
>>>>> crash, and is it a bug in DART or a documented requirement - and no,
>>>>> no need to research, just write what you know already).
>>>>>       
>>>>>           
>>>> Why ugly ? Anyway it's a way to avoid SIG_FPE, which is well-known 
>>>> problem on OS/2.
>>>>         
>>> Which does not explain what exactly this code is doing in an ao
>>> (changing that kind of thing is not commonly expected from an ao).
>>> There is also the obvious questions what causes a SIG_FPE, correctly
>>> written code should not cause any.
>>>       
>> Some AAC encoded movie causes SIG_FPE(underflow) in libfaad2.
>>     
>
> Does it also happen with -ac ffaac?  We will drop libfaad2 in hopefully
> not so distant future...
>
>   

Yes, it does. T.T

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 1.1.14
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 1 GHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr