[MPlayer-dev-eng] [PATCH 8/9] Use proper ifdef/ifndef when checking defines

Diego Biurrun diego at biurrun.de
Tue Feb 17 11:32:17 CET 2009


On Tue, Feb 17, 2009 at 08:34:53AM +0100, Hans-Christian Egtvedt wrote:
> On Mon, 16 Feb 2009 18:31:12 +0100
> Diego Biurrun <diego at biurrun.de> wrote:
> 
> > On Mon, Feb 16, 2009 at 05:16:57PM +0100, Hans-Christian Egtvedt
> > wrote:
> > > 
> > > --- a/libavcodec/bitstream.h
> > > +++ b/libavcodec/bitstream.h
> > > @@ -199,7 +199,7 @@ static inline void put_bits(PutBitContext *s,
> > > int n, unsigned int value) if (n >= bit_left) {
> > > -#if !HAVE_FAST_UNALIGNED
> > > +#ifndef HAVE_FAST_UNALIGNED
> > 
> > All of these are wrong, rejected.
> > 
> 
> The reason for my patch was that HAVE_FAST_UNALIGNED is not defined
> when I configure for AVR32, and I got warnings from GCC.

So you cut off both your arms and a leg when you feel a pain in your
stomach? :)

> Should this define be present somewhere after a ./configure?

Yes.  Look inside configure, you will find the definition in there.

Diego

P.S.: No need to CC me, I'm subscribed.



More information about the MPlayer-dev-eng mailing list