[MPlayer-dev-eng] [PATCH] get rid of mc_render_slice

Ivan Kalvachev ikalvachev at gmail.com
Mon Feb 16 22:21:02 CET 2009


On 2/14/09, Reimar Döffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> Hello,
> the two extra asserts and a few arithmetic operations less don't seem
> worth the extra function to me, particularly since inspires others (e.g.
> NVidia) to duplicate the code once more...
> I am also quite irritated at why those functions are set once in init
> and once in get_format (that code was never really reviewed, was it?).

Didn't read the patch carefully, but I would ask you to delay it for a while
because Michael have the idea of removing things from xvmc struct like
picture_structure and using same field from AVFrame. As draw_slice doesn't
forward this info it should be put back into extended_xvmc struct
and this could only be done in mc_render_slice function ...



More information about the MPlayer-dev-eng mailing list