[MPlayer-dev-eng] [PATCH 7/9] libswscale: Optimize yuv2rgb conversion for avr32

Diego Biurrun diego at biurrun.de
Mon Feb 16 18:38:28 CET 2009


On Mon, Feb 16, 2009 at 05:16:56PM +0100, Hans-Christian Egtvedt wrote:
> Implemented by Ronny Pedersen.
> 
> --- /dev/null
> +++ b/libswscale/pico-avr32.h
> @@ -0,0 +1,134 @@
> +#ifndef __PICO_H__
> +#define __PICO_H__

illegal identifier and wrong filename - two bugs in a single line..

> +/* Config Register */
> +#define PICO_COEFF_FRAC_BITS  0
> +#define PICO_COEFF_FRAC_BITS_WIDTH  4
> +#define PICO_OFFSET_FRAC_BITS  4
> +#define PICO_OFFSET_FRAC_BITS_WIDTH  4
> +#define PICO_INPUT_MODE  8
> +#define PICO_INPUT_MODE_WIDTH  2
> +#define PICO_OUTPUT_MODE 10

align, same in other places

> +#define __str(x...) #x
> +#define __xstr(x...) __str(x)

illegal identifier

> --- a/libswscale/yuv2rgb.c
> +++ b/libswscale/yuv2rgb.c
> @@ -520,7 +520,12 @@ SwsFunc sws_yuv2rgb_get_func_ptr (SwsContext *c)
> -
> +#ifdef ARCH_AVR32

wrong, use #if

> --- /dev/null
> +++ b/libswscale/yuv2rgb_avr32.c
> @@ -0,0 +1,413 @@
> +#include <libavutil/avutil.h>

libavutil headers are not system headers, use "".

Diego



More information about the MPlayer-dev-eng mailing list