[MPlayer-dev-eng] [PATCH] vdpau

[Reimar Döffinger]

On Mon, Feb 16, 2009 at 12:49:00PM +0100, Gwenole Beauchesne wrote:
> On Mon, 16 Feb 2009, Reimar Doeffinger wrote:
> >> Ah, didn't notice it was the new way to operate. Why is it so?
> >
> > Because vdpau is a proprietary library, thus most distributions will have to
> > (and should!) compile MPlayer without vdpau-support unless it is dlopened, or
> > in short: see the libdvdcss case (though we do not have the dlopen in MPlayer
> > itself, it is in the external libdvdread).
> 
> Yes, that makes sense but I think I read somewhere nvidia would try to 
> change at least the license for the wrapper library for this very reason.

It would make sense, and as soon as there is a GPL-compatibly licenses
libvdpau I am all for removing the dlopen.

> >> Beyond the fact that if their is an
> >> API change (and thus, a SONAME change), you'd pick up the wrong library.
> >
> > The API used via dlopen/dlsym consists of _exactly_ one single function,
> > vdp_device_create_x11.
> 
> which could have more or less args in the future, so don't assume anything 
> to be on the safe side.

Of course it is possible, but there should be no need for such a change.
Removing it maybe, but if the API consists of one function it is not
unreasonable to expect backward-compatibility.

> At the very least, add the version number.

Sure, I didn't mean to argue against that, I just had to check if there is a versioned variant.
I changed it to "libvdpau.so.1" locally.

Greetings,
Reimar Döffinger