[MPlayer-dev-eng] [PATCH] ao_dart

[KO Myung-Hun]

Hi/2.

Diego Biurrun wrote:
> On Mon, Feb 16, 2009 at 12:53:55AM +0900, KO Myung-Hun wrote:
>   
>> This patch add a ao_dart for OS/2 DART audio system.
>>
>> --- libao2/ao_dart.c    (revision 0)
>> +++ libao2/ao_dart.c    (revision 0)
>> @@ -0,0 +1,266 @@
>> +/*
>> + * libao2 DART Audio Output Driver for MPlayer
>>     
>
> DART audio output driver
>
> Maybe say something about OS/2.
>
>   

Ok.

>> +#define OUTBURST_SAMPLES    512
>> +#define DART_SAMPLES        ( OUTBURST_SAMPLES << 2 )
>>     
>
> I don't really like the way you add spaces inside parentheses.
>
>   

Fixed.

>> +static int get_space( void )
>> +{
>> +    return ( m_nBufSize - m_nBufLen );
>>     
>
> useless parentheses
>
>   

Fixed.

> This is missing a man page update, changelog update would also be nice.
>
>   

Added.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 1.1.14
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 1 GHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: dart.diff
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20090216/231dc617/attachment.txt>