[MPlayer-dev-eng] [PATCH] vdpau

[Gwenole Beauchesne]

Hi,

On Mon, 16 Feb 2009, Reimar Döffinger wrote:

>>> All current vdpau implementations use dl to open the implementation-
>>> specific
>>> shared vendor vdpau libraries, so vdpau will not work without dl.
>>
>> Then, it's a bug in the vdpau library. Any DSO shall have the set of
>> libraries it uses in DT_NEEDED. i.e. it's not the role of the target
>> application (or library) to include the deps of that library, unless
>> to workaround library bugs.
>
> He means it is needed anyway, because supporting e.g. two graphics cards
> by different vendors means you have to open the appropriate library
> after you know which one is needed.

I still don't see the problem and I also checked the libvdpau.so.1 library 
here, it has no problem at all. It requires libdl.so.2, which is the right 
thing already. There is no need to add anything to MPlayer, you only have 
link against libvdpau (it's the correct wrapper/loader library).

Again, it would have been the role of the library to explicitly link 
against libdl if it uses dlopen() et al., not MPlayer's. Don't bloat 
MPlayer deps if there is no need to, and there isn't.

Regards,
Gwenole.