[MPlayer-dev-eng] [PATCH] add VDPAU IMGFMTs

[Uoti Urpala]

On Thu, 2009-02-12 at 18:52 +0100, Reimar Döffinger wrote:
> this is part of the extremely work-in-progress vdpau branch at
> http://natsuki.mplayerhq.hu/~reimar/MPlayer.git/

I suggest you consider doing such changes which won't be relevant for
the release on top of my git branch instead of svn. The git branch is
getting to the point where it'll be a better choice for most users than
svn. Some general setup decisions are required before recommending it as
the version for bleeding-edge users and all developers but those can be
done before these changes are ready. I think the best plan is to make a
final release from svn and then move to git. (Of course there will be
some opposition to such a move, but I doubt anyone has a technically
competitive alternative plan for future development. If someone wants to
flame at least explain how you'd maintain a better version - and current
svn isn't one.)

BTW viewing that URL with a browser shows a page with outdated
information.

> It adds the IMGFMTs needed, and only those (so that there is a 1:1
> correspondence to the lavc ones, not split by profile).
> The profile handling, if necessary, should be done in the vo, since
> there would also be the code that can probe which profiles are
> officially supported by the device, and decide if it should try playing
> with a lower profile (betting on luck) or give up or whatever.
> It _might_ make it harder to do a software fallback, but it seems like a
> not-so-good idea to me to design for that yet since it IMO is unclear
> how a well-designed fallback solution would work - e.g. it should also
> take into account the maximum number of reference frames, which is not
> coded into the IMGFMT either.
> I can understand if you do not like this piecemeal approach to get this
> in, tell me if so, but I currently can't think of a better/faster way to get this
> in.

I don't see any major problem with doing it in such parts, but I don't
understand your rationale for it either. Why do you need to commit
nonfunctional parts if you're maintaining things as a git branch anyway?
I mean what benefit does it give to have this in svn instead of your git
branch?