[MPlayer-dev-eng] [PATCH] factor out panscan etc. calculation from xv, xvmc and direct3d

[Georgi Petrov]

On Wed, Feb 11, 2009 at 9:47 PM, Reimar Döffinger
<Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> Hello,
> this is mostly due to vo_direct3d and because vo_vdpau needs the same
> code.
> It adds a function calc_src_dst_rects that returns two rectangles that
> specify which part of the video (source) must be scaled onto which part of
> the window (destination).
> The reason for doing this for xvmc is that it is trivial to add
> support for cropping (and xv is changed to keep them at least somewhat
> consistent).
> After this patch, the only thing that is missing to support cropping is:
> a way for the vo to get cropping values (I'd be in favour of a VOCTRL),
> fixing up aspect due to the cropping,
> fixing the OSD so it does not get cropped as well and
> passing the cropping values to calc_src_dst_rects

I agree.