[MPlayer-dev-eng] [PATCH] '-priority' support on OS/2

Diego Biurrun diego at biurrun.de
Sun Feb 8 23:36:32 CET 2009


On Sun, Feb 08, 2009 at 09:45:15AM +0900, KO Myung-Hun wrote:
>
> Diego Biurrun wrote:
>>>>> @@ -721,6 +725,7 @@
>>>>>  _def_stream_cache="#define CONFIG_STREAM_CACHE 1"
>>>>>  _def_pthread_cache="#undef PTHREAD_CACHE"
>>>>>  _need_shmem=yes
>>>>> +_def_priority="#undef CONFIG_PRIORITY"
>>>>>             
>>>> Leave out the leading underscore from the variable name       
>>> I don't know what you mean. T.T
>>
>> Leave out the first _ from the variable name, i.e. 'def_priority'
>> instead of '_def_priority'.
>
> Of course, I know that. But I don't know why only '_def_priority' should  
> be done so.

You motivated me to finally address this.  Changed.

> --- configure   (revision 28306)
> +++ configure   (working copy)
> @@ -721,6 +725,7 @@
>  _def_stream_cache="#define CONFIG_STREAM_CACHE 1"
>  _def_pthread_cache="#undef PTHREAD_CACHE"
>  _need_shmem=yes
> +priority=no

Add the default #define here and override it in the system-specific
sections.

> --- osdep/priority.c    (revision 0)
> +++ osdep/priority.c    (revision 0)
> @@ -0,0 +1,90 @@
> +
> +#define _UWIN 1  /*disable Non-underscored versions of non-ANSI functions as otherwise int eof would conflict with eof()*/

Please move the comment above the definition.

Diego



More information about the MPlayer-dev-eng mailing list