[MPlayer-dev-eng] [PATCH] '-priority' support on OS/2

[Diego Biurrun]

On Fri, Feb 06, 2009 at 10:37:00PM +0900, KO Myung-Hun wrote:
>
> Diego Biurrun wrote:
>> On Thu, Feb 05, 2009 at 10:46:21PM +0900, KO Myung-Hun wrote:
>>   
>>> Diego Biurrun wrote:
>>>     
>>>> On Thu, Feb 05, 2009 at 02:09:49AM +0900, KO Myung-Hun wrote:
>>>>        
>>>>> I attach the updated patch.
>>>>>
>>>>> --- Makefile	(revision 28306)
>>>>> +++ Makefile	(working copy)
>>>>> @@ -433,6 +433,7 @@
>>>>>
>>>>> SRCS_COMMON-$(PNG) 				  += libmpcodecs/vd_mpng.c
>>>>> +SRCS_COMMON-$(PRIORITY)				 += osdep/$(PRIORITY_C)
>>>>> SRCS_COMMON-$(PVR) 				  += stream/stream_pvr.c
>>>>> SRCS_COMMON-$(QTX_CODECS)			  += libmpcodecs/ad_qtaudio.c \
>>>>>         
>>>> Suddenly this file is full of tabs, what happened?
>>>>       
>>> It's make file, so I compressed spaces to tab as the original. It 
>>> seems that tab is not matter, therefore I'll not convert spaces to 
>>> tab.
>>
>> The original has tabs only in the required places.  As a rule of thumb,
>> do not mess with whitespace.
>
> Hmm... See Makefile. There are many parts with a mixture of tabs and  
> spaces, where tabs are not required.

There is not a single line with a mixture of tabs and spaces in the
Makefile.

>>> @@ -721,6 +725,7 @@
>>>  _def_stream_cache="#define CONFIG_STREAM_CACHE 1"
>>>  _def_pthread_cache="#undef PTHREAD_CACHE"
>>>  _need_shmem=yes
>>> +_def_priority="#undef CONFIG_PRIORITY"
>>>     
>>
>> Leave out the leading underscore from the variable name 
>
> I don't know what you mean. T.T

Leave out the first _ from the variable name, i.e. 'def_priority'
instead of '_def_priority'.

>> and group all
>> the definition variables together.
>>
>> Also, something is wrong with your patch, these hunks are for configure,
>> not Makefile...
>
> Does this apply to _def_stream_cache and _def_pthread_cache ?

Try applying your patch, it does not apply because it is completely
broken.

Diego