[MPlayer-dev-eng] [PATCH] Fix 'make distclean'

[Diego Biurrun]

On Wed, Feb 04, 2009 at 07:35:21PM +0100, Reimar Döffinger wrote:
> On Wed, Feb 04, 2009 at 07:26:00PM +0100, Diego Biurrun wrote:
> > On Tue, Feb 03, 2009 at 12:53:39AM +0100, Reimar Döffinger wrote:
> > > On Tue, Feb 03, 2009 at 12:31:43AM +0100, Diego Biurrun wrote:
> > > > You have to run configure again after distclean.  Everything else is
> > > > undefined behavior.
> > > 
> > > I'd be thankful if you could find time to make things more reliable, two suggestions:
> > > 1) Ignore rm failure
> > > 2) add a to help_create.sh
> > > if test -r "$TRANSLATION" -a -n "$CHARSET" ; then
> > >   echo "bad parameters"
> > >   exit 1
> > > fi
> > 
> > What's the problem you are trying to solve here?
> 
> That help_create.sh creates a broken help_mp.h file instead of failing
> early and properly, e.g. when called without arguments, or wrong
> arguments (e.g. since because configure was not run).
> This would not make distclean more reliable, but it would avoid that
> "make" breaks the tree (though I admit I can not see or reproduce how
> that could happen).
> Still it seems nice of a program to print a message when you use it
> wrongly instead of just pages of e.g.
> "grep: : No such file or directory"

Done.

Diego